Fixed #4: TCP sockets for connection#7
Closed
sauravhiremath wants to merge 4 commits intobytesonus:masterfrom
Closed
Fixed #4: TCP sockets for connection#7sauravhiremath wants to merge 4 commits intobytesonus:masterfrom
sauravhiremath wants to merge 4 commits intobytesonus:masterfrom
Conversation
rakshith-ravi
approved these changes
Apr 28, 2020
Member
rakshith-ravi
left a comment
rakshith-ravi
left a comment
There was a problem hiding this comment.
Looks good to me.
Seems like some solid work. However, I'd like to get #5 merged before this gets merged so that we can have some CI testing done on PRs.
Member
|
Everything else seems fine. Let's get #5 merged before we merge this. |
rakshith-ravi
requested changes
Apr 30, 2020
Member
rakshith-ravi
left a comment
rakshith-ravi
left a comment
There was a problem hiding this comment.
Revert the CI parts. Those are a separate PR. Doesn't belong here
sauravhiremath
force-pushed
the
master
branch
2 times, most recently
from
4e16779 to
f50d4db
Compare
Contributor
Author
Yeah reverted the changes. But at least we know PR checks are working 😅 (The checks were successful when I added the unwanted commit to PR) |
Member
|
Can we have a new PR to target |
thebongy
added a commit
that referenced
this pull request
May 7, 2020
* feat #4: TCP sockets support added * feat #4: Error handling for socket path * fix #7: Import destructuring and minor fixes * fix #7: fs renamed to fsPromises * Update github repo link * fix: Don't fail build if just version check fails if not publishing release * 0.1.0 beta test release (#11) * fix: Correct downloaded atrifact name * Test staging release * Update build.yml * fix: Bump version in package.json on staging * fix: bump version * fix: rename tar file * fix: Rename tar only if doesn't exist * fix * Removed unnecessarry await * fix: Support passing data along with hook Closes #16 Co-authored-by: Saurav M. H <sauravhiremath@gmail.com> Co-authored-by: Rakshith Ravi <rakshith.ravi@gmx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.